SPC110203: Dispose SPWeb objects created with SPSite.OpenWeb

The OpenWeb method create an SPWeb object and return it to the caller. This new object is not stored in the SPSite object and is not disposed of anywhere in the SPSite class. For this reason, you should dispose of any object created via these methods.

TypeName: DisposeSPWebCreatedByOpenWeb
CheckId: SPC110203
Severity: CriticalWarning
Type: AssemblyFileReference
Resolution

Call Dispose on created SPWeb object or wrap instruction into using statement. See sample from MSDN:

Bad Coding Practice

void OpenWebLeak()
{
  using (SPSite siteCollection = new SPSite("http://moss"))
  {
    SPWeb web = siteCollection.OpenWeb();
    // SPWeb object web leaked.
  }  // SPSite object siteCollection.Dispose() automatically called.
}

Good Coding Practice
void OpenWebNoLeak()
{
  using (SPSite siteCollection = new SPSite("http://moss"))
  {
    using (SPWeb web = siteCollection.OpenWeb())
    {
    } // SPWeb object web.Dispose() automatically called.
  }  // SPSite object siteCollection.Dispose() automatically called.
}

Remarks

Rule relates to SPDisposeCheckId 'SPDisposeCheckID_120'. To ignore this rule add the attribute '[SPDisposeCheckIgnore(SPDisposeCheckID.SPDisposeCheckID_120, "Caller will dispose")]' to your method.

Links

comments powered by Disqus