SPC058911: Consider to not allow assignment in return statements |
Assigning values inside a return statement, can cause confusion as to the codes intent
| CheckId | SPC058911 |
|---|---|
| TypeName | NoAssignmentInReturn |
| Severity | Warning |
| Type | JavaScriptFile |
Bad Practice
function doSomething() {
return foo = bar + 2;
}
function doSomething() {
return foo += 2;
}
return foo = bar + 2;
}
function doSomething() {
return foo += 2;
}
Good Practice
function doSomething() {
return foo == bar + 2;
}
function doSomething() {
return foo === bar + 2;
}
return foo == bar + 2;
}
function doSomething() {
return foo === bar + 2;
}
Disclaimer: The views and opinions expressed in this documentation and in SPCAF do not necessarily reflect the opinions and recommendations of Microsoft or any member of Microsoft. SPCAF and RENCORE are registered trademarks of Rencore. All other trademarks, service marks, collective marks, copyrights, registered names, and marks used or cited by this documentation are the property of their respective owners.