Use inline array annotation for dependency injection in controllers |
Use inline array annotation for dependency injection in controllers
| CheckId | NG1120401 |
|---|---|
| TypeName | UseInlineArrayAnnotationForDIInControllers |
| Severity | CriticalWarning |
| Type | Controller |
Using inline array annotation for dependency injection improves the performance of AngularJS injecting dependencies into these functions as it doesn't need to dynamically discover these functions' dependencies.
Good practice
function HomeController($scope, dataService) {
// ...
}
angular.module('app')
.controller('HomeController', ['$scope', 'dataService', HomeController]);
// ...
}
angular.module('app')
.controller('HomeController', ['$scope', 'dataService', HomeController]);
Bad practice
function HomeController($scope, dataService) {
// ...
}
angular.module('app')
.controller('HomeController', HomeController);
// ...
}
angular.module('app')
.controller('HomeController', HomeController);
Disclaimer: The views and opinions expressed in this documentation and in SPCAF do not necessarily reflect the opinions and recommendations of Microsoft or any member of Microsoft. SPCAF and RENCORE are registered trademarks of Rencore. All other trademarks, service marks, collective marks, copyrights, registered names, and marks used or cited by this documentation are the property of their respective owners.