Do not use spaces in file or folders names
Instantiate a new SPSite inside RunWithElevatedPrivileges
Do not call SPList.Items.Add
Do not call SPList.Items
Do not call SPList.Items.GetItemById()
Do not call SPList.Items[]
Do not call SPList.Items.Count
Do not call SPListItemVersion.Delete to delete multiple versions
Do not call SPFileVersion.Delete to delete multiple versions
Do not enable ObjectTracking in Linq.DataContext
Do not access SPListCollection by indexer multiple times
Do not call SPFolder.Files.Count
Use SPBuiltInContentTypeId to reference builtin ContentType
Use SPBuiltInFieldId to reference builtin Field
Define RowLimit for SPQuery
Avoid using AppSettings to store configuration values
Apply lock when caching SharePoint objects
Do not call SPItemEventProperties.OpenWeb()
Do not request SPField from SPFieldCollection by index. Use SPFieldCollection.GetField() instead.
Do not call SPWeb.GetListFromUrl. Use SPWeb.GetListFromWebPartPageUrl instead.
Do not call PublishingWeb.GetPublishingPages()
Assign RowLimit for SPQuery in limited range
Use SPMonitoredScope with Developer Dashboard, on all custom code
Timer jobs instances should be created in a Feature Activated
Use SPMonitoredScope with Developer Dashboard, on all custom code
Do not activate or deactivate Features via API
Custom field types should not be user creatable
Attribute 'Name' and 'StaticName' should have the same value in Field
Consider setting attibute 'AllowDeletion' to FALSE in Field to prevent deletion by users
Consider using SPContentTypeCollection.BestMatch(SPContentTypeId) to retrieve a Content Type
Consider setting attibute 'Sealed' to TRUE in ContentType to prevent changes by users
Define Type of ListTemplate greater than 10000
Add ContentType for folders to ListTemplate
Avoid definition of ContentTypes in ListTemplates.
Consider setting attibute 'AllowDeletion' to FALSE in ListTemplate to prevent deletion by users
Do not instantiate SPList in Receiver
Do not instantiate SPListItem in Receiver
Do not instantiate SPSite in Receiver
Do not instantiate SPWeb in Receiver
Declare property 'AllowClose' in WebPart to prevent closing of webpart by the user
Expand Minimize

Do not call SPList.Items.Add

Do not call SPList.Items.Add. Use SPList.AddItem instead.

CheckId SPC050221
TypeName DoNotCallListItemsAddToAddItems
Severity CriticalWarning
Type Assembly
Resolution

Replace calls to SPList.Items.Add() with SPList.AddItem().
Bad Practice

SPWeb oWeb = SPContext.Current.Web;
SPList oList = oWeb.Lists["Tasks"];
SPListItem oItem = oList.Items.Add();
oItem["Title"] = "Title";
oItem.Update();

Good Practice
SPWeb oWeb = SPContext.Current.Web;
SPList oList = oWeb.Lists["Tasks"];
SPListItem oItem = oList.AddItem();
oItem["Title"] = "Title";
oItem.Update();

See also
Message Suppression

To suppress this violation in managed code add the following attribute to the method which contains the instruction (available since SPCAF version v5.2). Learn more about SuppressMessage here.

// Important: Ensure to have #define CODE_ANALYSIS at the beginning of your .cs file
[SuppressMessage("SPCAF.Rules.BestPracticesGroup", "SPC050221:DoNotCallListItemsAddToAddItems", Justification = "Provide reason for suppression here")]
Disclaimer: The views and opinions expressed in this documentation and in SPCAF do not necessarily reflect the opinions and recommendations of Microsoft or any member of Microsoft. SPCAF and RENCORE are registered trademarks of Rencore. All other trademarks, service marks, collective marks, copyrights, registered names, and marks used or cited by this documentation are the property of their respective owners.