Expand Minimize

Do not retrieve SPListItemCollection inside loop

Do not retrieve SPListItemCollection inside loop. Iterating through items of Sharepoint List, in every loop, if we request a new SPListItemCollection object when accessing the Items property. The Items property is not cached and therefore always requests all items from the database over and over again.

CheckId SPC220203
TypeName DoNotRetrieveListItemsInLoop
Severity CriticalWarning
Type Assembly

SPListItemCollection to be retrieved before iterating through the loop.

To suppress this violation in managed code add the following attribute to the method which contains the instruction (available since SPCAF version v5.2). Learn more about SuppressMessage here.

// Important: Ensure to have #define CODE_ANALYSIS at the beginning of your .cs file
[SuppressMessage("SPCAF.Rules.PerformanceGroup", "SPC220203:DoNotRetrieveListItemsInLoop", Justification = "Provide reason for suppression here")]
Disclaimer: The views and opinions expressed in this documentation and in SPCAF do not necessarily reflect the opinions and recommendations of Microsoft or any member of Microsoft. SPCAF and RENCORE are registered trademarks of Rencore. All other trademarks, service marks, collective marks, copyrights, registered names, and marks used or cited by this documentation are the property of their respective owners.